xCAT-client-2.5.1-alt0.4.noarch checkbashisms experimental checkbashisms utility found possible bashisms in: /usr/bin/wkill /usr/sbin/tabedit; xCAT-client-2.5.1-alt0.4.noarch missing-url info Missing Url: in a package.; xCAT-client-2.5.1-alt0.4.noarch rpm-filesystem-conflict-file-file warn There are file conflicts with the package pssh-2.3.1-alt1.noarch, for example, /usr/bin/prsync (4 file conflicts in total). Moreover, the packages have no explicit conflicts with each other. You should add explicit conflicts, or, if conflicts are avoidable, consider using alternatives.; File /usr/bin/pscp conflicts with the package putty-0.68-alt1.x86_64. Moreover, the packages have no explicit conflicts with each other. You should add explicit conflicts, or, if conflicts are avoidable, consider using alternatives.; xCAT-client-2.5.1-alt0.4.noarch unsafe-tmp-usage-in-scripts fail The test discovered scripts with errors which may be used by a user for damaging important system files. For example if a script uses in its work a temp file which is created in /tmp directory, then every user can create symlinks with the same name (pattern) in this directory in order to destroy or rewrite some system or another user's files. Scripts _must_ _use_ mktemp/tempfile or must use $TMPDIR. mktemp/tempfile is safest. $TMPDIR is safer than /tmp/ because libpam-tmpdir creates a subdirectory of /tmp that is only accessible by that user, and then sets TMPDIR and other variables to that. Hence, it doesn't matter nearly as much if you create a non-random filename, because nobody but you can access it. Found error in /usr/share/xcat/rvid/rvid.xen: $ grep -A5 -B5 /tmp/ /usr/share/xcat/rvid/rvid.xen ( flock 200 vncviewer :$myport -via $rvid_server AutoSelect=0 FullColor=1 >& /dev/null & sleep 0.2 flock -u 200 ) 200> /tmp/xcat/virtvnclock Found error in /usr/share/xcat/rvid/rvid.kvm: $ grep -A5 -B5 /tmp/ /usr/share/xcat/rvid/rvid.kvm ( flock 200 vncviewer :$myport -via $rvid_server AutoSelect=0 FullColor=1 >& /dev/null & sleep 0.2 flock -u 200 ) 200> /tmp/xcat/virtvnclock Found error in /usr/share/xcat/rvid/rvid.imm: $ grep -A5 -B5 /tmp/ /usr/share/xcat/rvid/rvid.imm #!/bin/bash # IBM(c) 2007 EPL license http://www.eclipse.org/legal/epl-v10.html mkdir -p /tmp/xcat JAVADETECTED=`which javaws 2> /dev/null` if [ -z "$JAVADETECTED" ]; then echo "Error: javaws not in path, unable to execute remote video" exit 1 fi echo $rvid_jnlp > /tmp/xcat/wvid_imm_$$.jnlp javaws /tmp/xcat/wvid_imm_$$.jnlp >& /dev/null if [ ! -z "$rvid_mediajnlp" ]; then echo $rvid_mediajnlp > /tmp/xcat/wvid_imm_media_$$.jnlp javaws /tmp/xcat/wvid_imm_media_$$.jnlp >& /dev/null rm /tmp/xcat/wvid_imm_media_$$.jnlp >& /dev/null fi rm /tmp/xcat/wvid_imm_$$.jnlp >& /dev/null Found error in /usr/sbin/tabedit: $ grep -A5 -B5 /tmp/ /usr/sbin/tabedit # IBM(c) 2007 EPL license http://www.eclipse.org/legal/epl-v10.html # Opens the specified table in the users editor;writes changes back to the db function cexit { if [ -d /tmp/tabedit.$$ ]; then rm -rf /tmp/tabedit.$$; fi exit } trap cexit 2 15 -- echo " tabedit [-? | -h | --help]"; exit 1 fi # Dump the table to a temporary file mkdir -p /tmp/tabedit.$$/ $XCATROOT/bin/xcatclientnnr tabdump $TABLE > /tmp/tabedit.$$/$TABLE.csv # Save the checksum to see if it actually changes.. if [ `uname` = "AIX" ]; then SUMPROGRAM=sum else SUMPROGRAM=md5sum fi SUM=`$SUMPROGRAM /tmp/tabedit.$$/$TABLE.csv` # Edit the file, then check it EXIT=0 while [ $EXIT -eq 0 ]; do cd /tmp/tabedit.$$ $TABEDITOR $TABLE.csv cd - >/dev/null NEWSUM=`$SUMPROGRAM /tmp/tabedit.$$/$TABLE.csv` if [ "$NEWSUM" == "$SUM" ]; then echo "No file modifications detected, not restoring." break; fi if `dirname $0`/tabrestore /tmp/tabedit.$$/$TABLE.csv; then break; else echo "Above errors occured, hit enter to edit, or ctrl-c to abort" read JNK fi;